From 33044731c883d3ab6c0c090c057bacd46043794a Mon Sep 17 00:00:00 2001 From: x3 Date: Mon, 7 Sep 2026 17:50:38 +0000 Subject: [PATCH] fix: rsync progress callback overwritten by SnapshotManager MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SnapshotManager::create_snapshot() set rsync_.on_progress = on_progress where on_progress was nullptr, destroying the MainWindow callback. Removed the line — MainWindow already sets rsync_.on_progress in ctor. --- src/snapshot_manager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/snapshot_manager.cpp b/src/snapshot_manager.cpp index c69646a..8c7a798 100644 --- a/src/snapshot_manager.cpp +++ b/src/snapshot_manager.cpp @@ -37,7 +37,8 @@ std::string SnapshotManager::create_snapshot(const std::string& description) { link_dest = snapshots[0].path; } - rsync_.on_progress = on_progress; + /* Do NOT overwrite rsync_.on_progress — MainWindow already set it */ + bool ok = rsync_.create_snapshot(ts, config_.settings().source_path, snapshots_dir, link_dest); if (ok) {