HIGH: Port number ignored when connecting via password dialog #3

Closed
opened 2026-09-07 15:00:49 +00:00 by x3 · 0 comments
Owner

Bug

The password dialog did not accept a port parameter. Servers with non-22 ports silently connected on port 22.

Fix

Added port parameter to show_password_dialog() and propagated it through the connect flow:

// BEFORE:
void show_password_dialog(const std::string& host, const std::string& user, ...);
connect_to_server(host, 22, user, ...); // always port 22

// AFTER:
void show_password_dialog(const std::string& host, int port, const std::string& user, ...);
connect_to_server(host, port, user, ...); // correct port

Status: Fixed in commit 4a2b2ea

## Bug The password dialog did not accept a port parameter. Servers with non-22 ports silently connected on port 22. ## Fix Added `port` parameter to `show_password_dialog()` and propagated it through the connect flow: ```cpp // BEFORE: void show_password_dialog(const std::string& host, const std::string& user, ...); connect_to_server(host, 22, user, ...); // always port 22 // AFTER: void show_password_dialog(const std::string& host, int port, const std::string& user, ...); connect_to_server(host, port, user, ...); // correct port ``` **Status:** Fixed in commit 4a2b2ea
x3 closed this issue 2026-09-07 16:58:14 +00:00
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: x3/x3-ssh#3