x3/x3-backup
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: rsync progress callback overwritten by SnapshotManager

Browse Source 
SnapshotManager::create_snapshot() set rsync_.on_progress = on_progress
where on_progress was nullptr, destroying the MainWindow callback.

Removed the line — MainWindow already sets rsync_.on_progress in ctor.
This commit is contained in:
x3
2026-09-07 17:50:38 +00:00
parent 7b50af6bbf
commit 33044731c8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/snapshot_manager.cpp
+2 -1
View File
@@ -37,7 +37,8 @@ std::string SnapshotManager::create_snapshot(const std::string& description) {
link_dest = snapshots[0].path; link_dest = snapshots[0].path;
} }
rsync_.on_progress = on_progress; /* Do NOT overwrite rsync_.on_progress — MainWindow already set it */
bool ok = rsync_.create_snapshot(ts, config_.settings().source_path, snapshots_dir, link_dest); bool ok = rsync_.create_snapshot(ts, config_.settings().source_path, snapshots_dir, link_dest);
if (ok) { if (ok) {